Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: listen to onload for stylesheets in before hook of tests #1131

Closed
wants to merge 1 commit into from
Closed

Refactor: listen to onload for stylesheets in before hook of tests #1131

wants to merge 1 commit into from

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Sep 12, 2018

This PR refactors the addStyleSheet helper for CSSOM based tests into axe.testUtils object. The function also returns a promise, thereby allowing to wait until the stylesheets are loaded in the before hook, thus ensuring assets are available before running respective tests.

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: << Name here >>

@jeeyyy jeeyyy requested a review from a team as a code owner September 12, 2018 05:00
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jey seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jeeyyy jeeyyy mentioned this pull request Sep 12, 2018
Closed
@jeeyyy jeeyyy changed the title refactor: for tests listen to onload for added stylesheets in before hook refactor: listen to onload for added stylesheets in before hook of tests Sep 12, 2018
@jeeyyy jeeyyy changed the title refactor: listen to onload for added stylesheets in before hook of tests refactor: listen to onload for stylesheets in before hook of tests Sep 12, 2018
@jeeyyy jeeyyy changed the title refactor: listen to onload for stylesheets in before hook of tests Refactor: listen to onload for stylesheets in before hook of tests Sep 12, 2018
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Sep 12, 2018

Meh! Had setup gitconfig to not recognise user, hence CLA was not passing. Had altered gitconfig and created a new PR with fresh commit of same changes. Hence closing this.

@jeeyyy jeeyyy closed this Sep 12, 2018
@jeeyyy jeeyyy deleted the add-sheets-onload-listener branch November 6, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeeyyy @CLAassistant